Alexei Kotov
55107e0913
Merge branch 'idle_select_to_group_name' into 'master'
...
Build and test / Ubuntu (push) Waiting to run
Build and test / MacOS (push) Waiting to run
Build and test / Read .env file and expose it as output (push) Waiting to run
Build and test / Windows (2019) (push) Blocked by required conditions
Build and test / Windows (2022) (push) Blocked by required conditions
Use string_view for sIdleSelectToGroupName
See merge request OpenMW/openmw!4646
2025-04-28 03:02:17 +03:00
Alexei Kotov
011dfb305c
Merge branch 'navmeshtool_lib' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Do not build navmeshtool translation units twice
See merge request OpenMW/openmw!4647
2025-04-25 21:40:57 +03:00
elsid
fc4cc3255d
Do not build navmeshtool translation units twice
2025-04-24 23:03:07 +02:00
elsid
f487a6332b
Use string_view for sIdleSelectToGroupName
2025-04-24 23:01:30 +02:00
psi29a
80d6f020ed
Merge branch 'apt_get_retry' into 'master'
...
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Ubuntu (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Retry apt-get update and add-apt-repository
See merge request OpenMW/openmw!4639
2025-04-24 09:07:20 +00:00
psi29a
c7c95c5a85
Merge branch 'fix-bug-8462' into 'master'
...
Set SDL_HINT_MAC_OPENGL_ASYNC_DISPATCH.
Closes #8225 and #8462
See merge request OpenMW/openmw!4641
2025-04-24 09:06:27 +00:00
Sam Kaufman
1948ab21f7
Set SDL_HINT_MAC_OPENGL_ASYNC_DISPATCH.
...
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Ubuntu (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
This fixes bugs #8225 and #8462 .
2025-04-23 20:33:56 -07:00
Alexei Kotov
ca3a286cc4
Merge branch 'master' into 'master'
...
Build and test / MacOS (push) Waiting to run
Build and test / Read .env file and expose it as output (push) Waiting to run
Build and test / Windows (2019) (push) Blocked by required conditions
Build and test / Windows (2022) (push) Blocked by required conditions
Build and test / Ubuntu (push) Waiting to run
FIX: Clarify that `ignore` field of raycast options types are a list and not a single object
See merge request OpenMW/openmw!4613
2025-04-24 02:09:47 +03:00
Evil Eye
ab5070328d
Merge branch 'powershell-multiline-exit' into 'master'
...
Detect failures in multiline PowerShell commands
See merge request OpenMW/openmw!4645
2025-04-23 18:54:47 +00:00
Evil Eye
23522ed314
Merge branch 'missing_enum' into 'master'
...
Add missing TargetPolygonNotFound enum value to lua bindings
See merge request OpenMW/openmw!4643
2025-04-23 18:54:46 +00:00
Evil Eye
b4d5013679
Merge branch 'lua_state' into 'master'
...
Use unique_ptr to handle lua state lifetime
See merge request OpenMW/openmw!4636
2025-04-23 18:54:40 +00:00
Dave Corley
5ef2cf23b3
CLEANUP: Loop param, also, is a bool
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Ubuntu (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
2025-04-23 11:20:46 -07:00
elsid
8ee0c9e7be
Retry apt-get update and add-apt-repository
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Ubuntu (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
2025-04-22 23:05:27 +02:00
AnyOldName3
19725473d7
Detect failures in multiline PowerShell commands
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
GitLab inserts a check for failure after each command in our `script`.
This is documented here https://docs.gitlab.com/runner/shells/#powershell
However, it doesn't detect failures if we run commands back to back.
This adds the checks GitLab would have added for us if we were able to make it do that.
2025-04-22 20:58:43 +01:00
psi29a
aed135a7c0
Merge branch 'bump-cache-key' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Increment cache keys missed in !4450
Closes #8463
See merge request OpenMW/openmw!4644
2025-04-22 07:05:45 +00:00
AnyOldName3
928bbed09b
Increment cache keys missed in !4450
...
It changed the filenames for deps, so we've got two copies of the deps in the cache, and now we're running out of disk space.
2025-04-21 22:52:24 +01:00
elsid
626d7b2282
Add missing TargetPolygonNotFound enum value to lua bindings
2025-04-21 16:36:19 +02:00
Evil Eye
e20d52d23c
Merge branch 'namespace_typo' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Fix typo in namespace name
See merge request OpenMW/openmw!4635
2025-04-21 08:41:27 +00:00
Evil Eye
05c624bc34
Merge branch 'rm_using_namespace_fallback' into 'master'
...
Remove redundant using namespace Fallback
See merge request OpenMW/openmw!4638
2025-04-21 08:39:48 +00:00
Evil Eye
5a42db3256
Merge branch 'static_assert' into 'master'
...
Use static_assert for compile time check
See merge request OpenMW/openmw!4637
2025-04-21 08:35:17 +00:00
elsid
6f89d38b78
Replace includes by forward declaration
2025-04-20 02:28:34 +02:00
elsid
042c4b2b9d
Use static_assert for compile time check
2025-04-18 14:38:23 +02:00
elsid
f80283422f
Use unique_ptr to handle lua state lifetime
2025-04-18 14:01:07 +02:00
elsid
972995d124
Fix typo in namespace name
2025-04-18 12:27:48 +02:00
elsid
0d5e9ef85f
Remove redundant using namespace Fallback
...
C++ has ADL to find overloads. using namespace does nothing in this
case.
2025-04-18 12:27:37 +02:00
psi29a
87d77a6882
Merge branch 'rippleshaders' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Fix crash if ripple pipeline shaders are unavailable
See merge request OpenMW/openmw!4622
2025-04-17 09:26:12 +00:00
Alexei Kotov
c1c8769742
Merge branch 'clang_tidy_identifier_naming' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Enable identifier naming clang-tidy check (#8424 )
See merge request OpenMW/openmw!4631
2025-04-14 13:39:09 +03:00
Alexei Kotov
271ab2e109
Merge branch 'dont-ask-the-disk-for-things-we-already-know' into 'master'
...
Avoid IO in resolveParentFileIndices
See merge request OpenMW/openmw!4627
2025-04-14 13:11:57 +03:00
Alexei Kotov
583620e607
Merge branch 'patch-1' into 'master'
...
Crimes.lua wrong type for victim aware
See merge request OpenMW/openmw!4623
2025-04-14 09:44:45 +03:00
psi29a
6dd2cac3ec
Merge branch 'better-freeze-catcher' into 'master'
...
Build and test / Ubuntu (push) Waiting to run
Build and test / MacOS (push) Waiting to run
Build and test / Read .env file and expose it as output (push) Waiting to run
Build and test / Windows (2019) (push) Blocked by required conditions
Build and test / Windows (2022) (push) Blocked by required conditions
Improve Windows crash/freeze catcher UX
See merge request OpenMW/openmw!4630
2025-04-13 20:57:12 +00:00
Alexei Kotov
6aed2d8284
Bump Crimes interface version
2025-04-13 14:05:07 +03:00
elsid
84f471ce5c
Enable identifier naming clang-tidy check
2025-04-13 09:59:51 +02:00
AnyOldName3
deb070389f
Improve Windows crash/freeze catcher UX
...
* Change crash log to crash dump in messages.
* Make the freeze catcher popup disappear more quickly when OpenMW thaws - we got a few freeze dumps from after a thaw.
* Improve freeze catcher message - hopefully fewer users think it's a false positive they're expected to put up with and we get future reports sooner.
2025-04-12 18:38:55 +01:00
Alexei Kotov
f7f148a6ca
Merge branch 'fix-debug-config' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Fix Windows Debug build
See merge request OpenMW/openmw!4629
2025-04-12 17:35:03 +03:00
AnyOldName3
a5a6f33578
Manual reformatting that wasn't done automatically on my machine
2025-04-11 17:41:40 +01:00
AnyOldName3
d74a0edb82
Format
2025-04-11 17:37:55 +01:00
AnyOldName3
396cd1c727
Fix Windows Debug build
...
This was a regression from https://gitlab.com/OpenMW/openmw/-/merge_requests/4596
Also move more things into the anonymous namespace because there's not really a reason not to and I had to rearrange things anyway.
2025-04-11 17:33:19 +01:00
AnyOldName3
31fcc5e126
Add test for new ReadersCache functions
2025-04-11 17:30:56 +01:00
Dave Corley
22172f3b0e
FIX: useAmbientLighting arg of addVfx options is a bool
2025-04-10 11:48:57 -07:00
Dave Corley
b68935e917
FIX: Model param of addVfx should not be a header
2025-04-10 11:44:34 -07:00
Dave Corley
e512a8e74f
FIX: Add a name to options table in castRenderingRay
2025-04-10 11:42:24 -07:00
AnyOldName3
48572e4c96
Even more elses
2025-04-10 18:32:52 +01:00
Dave Corley
1d1ae1c906
CLEANUP: But it can also be a single object
2025-04-10 10:15:31 -07:00
Dave Corley
586467540b
FIX: Clarify that ignore field of raycast options types are a list and not a single object
2025-04-10 10:15:31 -07:00
AnyOldName3
37dc1a6a76
Remove redundant elses
2025-04-10 16:51:23 +01:00
AnyOldName3
15162a734d
Avoid IO in resolveParentFileIndices
...
In the olden days, we passed it a vector of open ESMReader instances, as they knew the filenames and sizes, so were a convenient source of this knowledge.
When the ReadersCache was introduced as a pool of readers to limit the maximum number of simultaneously open file handles (to avoid going over the OS' limit) it was a poor substitute.
* We iterate over all the earlier readers in order in a double loop, which is the worst case scenario for an LRU pool as once we're past the size limit, we're guaranteed maximum thrashing - the least recently used item is the most likely to be used next, so the worst to evict.
* We didn't want to read any ESM files, just know whether they'd been read and what their sizes were, so didn't want to open a file handle, which the ReadersCache forced us to do.
Obviously, opening lots of file handles isn't fast, and as this was an operation done for each content file which iterated over the file's masters and within that loop iterated over every loaded file, that's O(n^3) complexity in the worst case, and for things like delta plugin merged plugins, they hit the worst case in long load orders.
This resolves the freeze reported as https://gitlab.com/OpenMW/openmw/-/issues/8425 , but there may be other freezes on launch.
2025-04-10 16:16:19 +01:00
psi29a
ea8369eff0
Merge branch 'dont-redraw-the-whole-gui-every-time-we-change-the-tiniest-thing' into 'master'
...
Build and test / Ubuntu (push) Has been cancelled
Build and test / MacOS (push) Has been cancelled
Build and test / Read .env file and expose it as output (push) Has been cancelled
Build and test / Windows (2019) (push) Has been cancelled
Build and test / Windows (2022) (push) Has been cancelled
Be more careful when we tell Qt that data has changed
Closes #8405
See merge request OpenMW/openmw!4621
2025-04-09 11:19:32 +00:00
AnyOldName3
096759435a
Add progress bars where the launcher can be limited by IO
...
I tested this with a USB3 external hard drive.
These two places were the only ones where we're IO-bound and block the main thread, so they're the only ones that need progress bars.
If trying to replicate this test, then it's important to unplug the hard drive between each repeat.
Apparently Windows is excellent at disk caching these days as it takes a minute and a half to start the launcher with Total Overhaul on this drive when it's just been plugged in, but less time than the first launch after a reboot on an NVME drive once the cache has been warmed up.
2025-04-09 01:36:52 +01:00
AnyOldName3
894ea4ba62
Don't precompute load order errors after every change
...
It's much slower than doing it on demand as it only takes a microsecond, but for a really big load order, there are hundreds of thousands of intermediate calls before everything's set up and we can draw the GUI.
2025-04-08 01:19:24 +01:00
AnyOldName3
d6b61f1f54
Sprinkle some const&
...
QStringView required more fighting as loads of call sites take a const&
2025-04-08 00:34:45 +01:00
