From 973282e471154b7821ffbfaa6ad62d8a19668722 Mon Sep 17 00:00:00 2001 From: AnyOldName3 Date: Sun, 6 Apr 2025 02:45:28 +0100 Subject: [PATCH] Optimise ContentSelectorModel::ContentModel::item This saves about 5% of remaining launcher startup time Not using fileProperty avoids loads of QVariant conversions. --- components/contentselector/model/contentmodel.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/components/contentselector/model/contentmodel.cpp b/components/contentselector/model/contentmodel.cpp index d7222f92f3..4ec7324e5d 100644 --- a/components/contentselector/model/contentmodel.cpp +++ b/components/contentselector/model/contentmodel.cpp @@ -78,14 +78,10 @@ ContentSelectorModel::EsmFile* ContentSelectorModel::ContentModel::item(int row) } const ContentSelectorModel::EsmFile* ContentSelectorModel::ContentModel::item(const QString& name) const { - EsmFile::FileProperty fp = EsmFile::FileProperty_FileName; - - if (name.contains('/')) - fp = EsmFile::FileProperty_FilePath; - + bool path = name.contains('/'); for (const EsmFile* file : mFiles) { - if (name.compare(file->fileProperty(fp).toString(), Qt::CaseInsensitive) == 0) + if (name.compare(path ? file->filePath() : file->fileName(), Qt::CaseInsensitive) == 0) return file; } return nullptr;