Archive/openmohaa
0
0
Fork 0
mirror of https://github.com/openmoh/openmohaa.git synced 2025-04-28 21:57:57 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixed cmd execution while iterating over a target list

Browse source
This commit is contained in:
smallmodel 2023-08-17 03:04:01 +02:00
parent 8487099264
commit 73bc196592
No known key found for this signature in database
GPG key ID: A96F163ED4891440
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
code/script/scriptvm.cpp
View file

@ -628,8 +628,8 @@ void ScriptVM::execCmdCommon(op_parmNum_t param)
void ScriptVM::execCmdMethodCommon(op_parmNum_t param)
{
const ScriptVariable& a = m_VMStack.Pop();
const op_ev_t eventNum = fetchOpcodeValue<op_ev_t>();
const ScriptVariable& a = m_VMStack.Pop();
const op_ev_t eventNum = fetchOpcodeValue<op_ev_t>();
m_VMStack.Pop(param);
@ -639,9 +639,15 @@ void ScriptVM::execCmdMethodCommon(op_parmNum_t param)
}
if (arraysize > 1) {
if (a.IsConstArray()) {
for (uintptr_t i = 1; i <= arraysize; i++) {
Listener *const listener = a.listenerAt(i);
if (a.IsConstArray()) {
// copy the variable
// because if it's a targetlist, the container object can be modified
// while iterating
ScriptVariable array = a;
for (uintptr_t i = arraysize; i > 0; i--) {
Listener *const listener = array.listenerAt(i);
// if the listener is NULL, don't throw an exception
// it would be unfair if the other listeners executed the command
if (listener) {