Archive/openmohaa
0
0
Fork 0
mirror of https://github.com/openmoh/openmohaa.git synced 2025-04-28 13:47:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check for valid scoreboard menu
Some checks failed
Build branch / build-all (push) Failing after 1m11s
Details
CodeQL / Analyze (push) Has been cancelled
Details

Browse source 
Under rare circumstances, the scoreboard menu can be NULL and would cause a crash. This was fixed in mohaab 2.30
This commit is contained in:
smallmodel 2025-04-15 18:37:24 +02:00
parent cf8af91516
commit 2a1e2d7d6c
No known key found for this signature in database
GPG key ID: 9F2D623CEDF08512
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
code/client/cl_ui.cpp
View file

@ -4372,10 +4372,8 @@ UI_ShowScoreboard_f
void UI_ShowScoreboard_f(const char *pszMenuName)
{
if (pszMenuName) {
if (scoreboard_menuname.length()) {
if (str::icmp(scoreboard_menuname, pszMenuName)) {
scoreboard_menu->ForceHide();
}
if (scoreboard_menuname.length() && str::icmp(scoreboard_menuname, pszMenuName) && scoreboard_menu) {
scoreboard_menu->ForceHide();
}
scoreboard_menuname = pszMenuName;
@ -4424,7 +4422,10 @@ void UI_HideScoreboard_f(void)
}
if (scoreboard_menuname.length()) {
scoreboard_menu->ForceHide();
// Fixed in 2.30 (scoreboard_menu check)
if (scoreboard_menu) {
scoreboard_menu->ForceHide();
}
}
}