Archive/openmohaa
0
0
Fork 0
mirror of https://github.com/openmoh/openmohaa.git synced 2025-04-28 13:47:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove controllers that don't have an associated entity

Browse source 
This prevents crashes when the entity was removed (potentially by a mod)
This commit is contained in:
smallmodel 2025-01-16 22:28:37 +01:00
parent 95e72dd339
commit 210eeff481
No known key found for this signature in database
GPG key ID: 9F2D623CEDF08512
1 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
code/fgame/playerbot.cpp
View file

@ -1198,6 +1198,19 @@ void BotControllerManager::ThinkControllers()
{
int i;
// Delete controllers that don't have associated player entity
// This cannot happen unless some mods remove them
for (i = controllers.NumObjects(); i > 0; i--) {
BotController* controller = controllers.ObjectAt(i);
if (!controller->getControlledEntity()) {
gi.DPrintf("Bot %d has no associated player entity. This shouldn't happen unless the entity has been removed by a script. The controller will be removed, please fix.\n", i);
// Remove the controller, it will be recreated later to match `sv_numbots`
delete controller;
controllers.RemoveObjectAt(i);
}
}
for (i = 1; i <= controllers.NumObjects(); i++) {
BotController *controller = controllers.ObjectAt(i);
controller->Think();