diff --git a/Source/Android/jni/ButtonManager.cpp b/Source/Android/jni/ButtonManager.cpp index fafc2ebe4d..7530e37cfd 100644 --- a/Source/Android/jni/ButtonManager.cpp +++ b/Source/Android/jni/ButtonManager.cpp @@ -2,6 +2,7 @@ // Licensed under GPLv2+ // Refer to the license.txt file included. +#include #include #include #include @@ -14,9 +15,10 @@ namespace ButtonManager { -const std::string touchScreenKey = "Touchscreen"; -std::unordered_map m_controllers; -std::vector configStrings = { +namespace +{ +constexpr char touchScreenKey[] = "Touchscreen"; +constexpr std::array configStrings{{ // GC "InputA", "InputB", @@ -168,8 +170,9 @@ std::vector configStrings = { "TurntableCrossRight", // Rumble "Rumble", -}; -std::vector configTypes = { +}}; + +constexpr std::array configTypes{{ // GC BUTTON_A, BUTTON_B, @@ -321,9 +324,11 @@ std::vector configTypes = { TURNTABLE_CROSSFADE_RIGHT, // Rumble RUMBLE, -}; +}}; -static void AddBind(const std::string& dev, sBind* bind) +std::unordered_map m_controllers; + +void AddBind(const std::string& dev, sBind* bind) { auto it = m_controllers.find(dev); if (it != m_controllers.end()) @@ -334,6 +339,7 @@ static void AddBind(const std::string& dev, sBind* bind) m_controllers[dev] = new InputDevice(dev); m_controllers[dev]->AddBind(bind); } +} // Anonymous namespace void Init(const std::string& gameId) { diff --git a/Source/Core/UICommon/ResourcePack/Manager.cpp b/Source/Core/UICommon/ResourcePack/Manager.cpp index 0d2327e56e..1be409f6e6 100644 --- a/Source/Core/UICommon/ResourcePack/Manager.cpp +++ b/Source/Core/UICommon/ResourcePack/Manager.cpp @@ -11,15 +11,13 @@ #include -namespace -{ -std::vector packs; - -std::string packs_path; -} // namespace - namespace ResourcePack { +namespace +{ +std::vector packs; +std::string packs_path; + IniFile GetPackConfig() { packs_path = File::GetUserPath(D_RESOURCEPACK_IDX) + "/Packs.ini"; @@ -29,6 +27,7 @@ IniFile GetPackConfig() return file; } +} // Anonymous namespace bool Init() {