Archive/android_translation_layer
0
0
Fork 0
mirror of https://gitlab.com/android_translation_layer/android_translation_layer.git synced 2025-04-28 12:17:57 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ViewGroup: keep track of detachedChildren

Browse source 
Some ViewGroups like ViewPager2 call attachViewToParent() without
calling detachViewFromParent() first. This is not allowed according to
the Android API spec, but we need to handle it.
This commit is contained in:
Julian Winkler 2025-03-25 19:55:31 +01:00
parent 4a4b4a4722
commit caa4700487
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/api-impl/android/view/ViewGroup.java
View file

@ -15,6 +15,7 @@ import java.util.Objects;
public class ViewGroup extends View implements ViewParent, ViewManager {
public ArrayList<View> children;
private ArrayList<View> detachedChildren;
private OnHierarchyChangeListener onHierarchyChangeListener;
private LayoutTransition transition;
@ -34,6 +35,7 @@ public class ViewGroup extends View implements ViewParent, ViewManager {
super(context, attrs, defStyleAttr);
children = new ArrayList<View>();
detachedChildren = new ArrayList<View>();
}
public void addView(View child) {
@ -136,10 +138,15 @@ public class ViewGroup extends View implements ViewParent, ViewManager {
}
public void detachViewFromParent(int index) {
children.remove(index).parent = null;
View child = children.remove(index);
child.parent = null;
detachedChildren.add(child);
}
public void attachViewToParent(View view, int index, LayoutParams params) {
if (!detachedChildren.remove(view)) {
addViewInternal(view, index, params);
}
if (!checkLayoutParams(params))
params = generateLayoutParams(params);
@ -151,6 +158,9 @@ public class ViewGroup extends View implements ViewParent, ViewManager {
}
protected void removeDetachedView(View child, boolean animate) {
if (!detachedChildren.remove(child))
return;
child.parent = null;
native_removeView(widget, child.widget);
if (isAttachedToWindow())
child.detachFromWindowInternal();
@ -388,6 +398,7 @@ public class ViewGroup extends View implements ViewParent, ViewManager {
public void detachViewFromParent(View view) {
children.remove(view);
view.parent = null;
detachedChildren.add(view);
}
public void setTouchscreenBlocksFocus(boolean touchscreenBlocksFocus) {}