diff --git a/TR5Main/Game/effects/weather.cpp b/TR5Main/Game/effects/weather.cpp index f57fa97ea..7ff65b19f 100644 --- a/TR5Main/Game/effects/weather.cpp +++ b/TR5Main/Game/effects/weather.cpp @@ -17,7 +17,7 @@ namespace Environment { EnvironmentController Weather; - float WeatherParticle::Transparency() + float WeatherParticle::Transparency() const { float result = WEATHER_PARTICLES_TRANSPARENCY; @@ -210,10 +210,8 @@ namespace Environment void EnvironmentController::UpdateWeather(GameScriptLevel* level) { - for (int i = 0; i < Particles.size(); i++) + for (auto& p : Particles) { - auto& p = Particles[i]; - auto oldPos = p.Position; if (!p.Stopped) diff --git a/TR5Main/Game/effects/weather.h b/TR5Main/Game/effects/weather.h index 42d8fdab4..8b7116d4b 100644 --- a/TR5Main/Game/effects/weather.h +++ b/TR5Main/Game/effects/weather.h @@ -18,7 +18,6 @@ namespace Environment constexpr auto WEATHER_PARTICLES_TRANSPARENCY = 0.8f; constexpr auto WEATHER_PARTICLES_NEAR_DEATH_LIFE_VALUE = 16; - constexpr auto SKY_POSITION_LIMIT = 9728; enum class WeatherType @@ -43,10 +42,9 @@ namespace Environment bool Enabled; bool Stopped; - float Transparency(); + float Transparency() const; }; - class EnvironmentController { public: diff --git a/TR5Main/Renderer/Renderer11DrawEffect.cpp b/TR5Main/Renderer/Renderer11DrawEffect.cpp index 845f52685..741377bc7 100644 --- a/TR5Main/Renderer/Renderer11DrawEffect.cpp +++ b/TR5Main/Renderer/Renderer11DrawEffect.cpp @@ -417,7 +417,7 @@ namespace TEN::Renderer void Renderer11::drawWeatherParticles(RenderView& view) { - for (auto p : Weather.GetParticles()) + for (auto& p : Weather.GetParticles()) { if (!p.Enabled) continue;