Fix some parameter values that were implicitly converted to RETURN_VALUE.

This commit is contained in:
Jean-Philip Desjardins 2024-01-17 17:00:22 -05:00
parent 97535eb31e
commit c2399cdf34
8 changed files with 17 additions and 17 deletions

View file

@ -570,7 +570,7 @@ void CCOP_FPU::LWC1()
m_codeGen->PushCtx();
m_codeGen->PushIdx(1);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_GetWordProxy), 2, true);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_GetWordProxy), 2, Jitter::CJitter::RETURN_VALUE_32);
m_codeGen->PullRel(offsetof(CMIPS, m_State.nCOP1[m_ft]));
@ -610,7 +610,7 @@ void CCOP_FPU::SWC1()
m_codeGen->PushCtx();
m_codeGen->PushRel(offsetof(CMIPS, m_State.nCOP1[m_ft]));
m_codeGen->PushIdx(2);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_SetWordProxy), 3, false);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_SetWordProxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
m_codeGen->PullTop();
}

View file

@ -606,7 +606,7 @@ void CMA_MIPSIV::LWL()
ComputeMemAccessAddrNoXlat();
m_codeGen->PushRel(offsetof(CMIPS, m_State.nGPR[m_nRT].nV[0]));
m_codeGen->PushCtx();
m_codeGen->Call(reinterpret_cast<void*>(&LWL_Proxy), 3, true);
m_codeGen->Call(reinterpret_cast<void*>(&LWL_Proxy), 3, Jitter::CJitter::RETURN_VALUE_32);
if(m_regSize == MIPS_REGSIZE_64)
{
@ -645,7 +645,7 @@ void CMA_MIPSIV::LWR()
ComputeMemAccessAddrNoXlat();
m_codeGen->PushRel(offsetof(CMIPS, m_State.nGPR[m_nRT].nV[0]));
m_codeGen->PushCtx();
m_codeGen->Call(reinterpret_cast<void*>(&LWR_Proxy), 3, true);
m_codeGen->Call(reinterpret_cast<void*>(&LWR_Proxy), 3, Jitter::CJitter::RETURN_VALUE_32);
if(m_regSize == MIPS_REGSIZE_64)
{
@ -681,7 +681,7 @@ void CMA_MIPSIV::SWL()
ComputeMemAccessAddrNoXlat();
m_codeGen->PushRel(offsetof(CMIPS, m_State.nGPR[m_nRT].nV[0]));
m_codeGen->PushCtx();
m_codeGen->Call(reinterpret_cast<void*>(&SWL_Proxy), 3, false);
m_codeGen->Call(reinterpret_cast<void*>(&SWL_Proxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
}
//2B
@ -698,7 +698,7 @@ void CMA_MIPSIV::SDL()
ComputeMemAccessAddrNoXlat();
m_codeGen->PushRel64(offsetof(CMIPS, m_State.nGPR[m_nRT]));
m_codeGen->PushCtx();
m_codeGen->Call(reinterpret_cast<void*>(&SDL_Proxy), 3, false);
m_codeGen->Call(reinterpret_cast<void*>(&SDL_Proxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
}
//2D
@ -709,7 +709,7 @@ void CMA_MIPSIV::SDR()
ComputeMemAccessAddrNoXlat();
m_codeGen->PushRel64(offsetof(CMIPS, m_State.nGPR[m_nRT]));
m_codeGen->PushCtx();
m_codeGen->Call(reinterpret_cast<void*>(&SDR_Proxy), 3, false);
m_codeGen->Call(reinterpret_cast<void*>(&SDR_Proxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
}
//2E
@ -719,7 +719,7 @@ void CMA_MIPSIV::SWR()
ComputeMemAccessAddrNoXlat();
m_codeGen->PushRel(offsetof(CMIPS, m_State.nGPR[m_nRT].nV[0]));
m_codeGen->PushCtx();
m_codeGen->Call(reinterpret_cast<void*>(&SWR_Proxy), 3, false);
m_codeGen->Call(reinterpret_cast<void*>(&SWR_Proxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
}
//2F

View file

@ -116,7 +116,7 @@ void CMA_MIPSIV::Template_Load32Idx(const MemoryAccessIdxTraits& traits)
m_codeGen->PushCtx();
m_codeGen->PushIdx(1);
m_codeGen->Call(traits.getProxyFunction, 2, true);
m_codeGen->Call(traits.getProxyFunction, 2, Jitter::CJitter::RETURN_VALUE_32);
finishLoad();
@ -157,7 +157,7 @@ void CMA_MIPSIV::Template_Store32Idx(const MemoryAccessIdxTraits& traits)
m_codeGen->PushCtx();
m_codeGen->PushRel(offsetof(CMIPS, m_State.nGPR[m_nRT].nV[0]));
m_codeGen->PushIdx(2);
m_codeGen->Call(traits.setProxyFunction, 3, false);
m_codeGen->Call(traits.setProxyFunction, 3, Jitter::CJitter::RETURN_VALUE_NONE);
m_codeGen->PullTop();
}

View file

@ -55,7 +55,7 @@ void CMIPSInstructionFactory::CheckTLBExceptions(bool isWrite)
m_codeGen->PushCst(isWrite ? 1 : 0);
//Call
m_codeGen->Call(reinterpret_cast<void*>(m_pCtx->m_TLBExceptionChecker), 3, true);
m_codeGen->Call(reinterpret_cast<void*>(m_pCtx->m_TLBExceptionChecker), 3, Jitter::CJitter::RETURN_VALUE_32);
m_codeGen->PushCst(MIPS_EXCEPTION_NONE);
m_codeGen->BeginIf(Jitter::CONDITION_NE);
@ -114,7 +114,7 @@ void CMIPSInstructionFactory::ComputeMemAccessAddr()
}
//Call
m_codeGen->Call(reinterpret_cast<void*>(m_pCtx->m_pAddrTranslator), 2, true);
m_codeGen->Call(reinterpret_cast<void*>(m_pCtx->m_pAddrTranslator), 2, Jitter::CJitter::RETURN_VALUE_32);
}
}

View file

@ -298,7 +298,7 @@ void CCOP_VU::CTC2()
m_codeGen->PushCursor(valueCursor);
//Compute Address
m_codeGen->PushCst(CVpu::EE_ADDR_VU_CMSAR1);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_SetWordProxy), 3, false);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_SetWordProxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
//Clear stack
assert(m_codeGen->GetTopCursor() == valueCursor);
m_codeGen->PullTop();

View file

@ -637,7 +637,7 @@ void CMA_VU::CLower::XTOP()
//Compute Address
m_codeGen->PushCst(CVpu::VU_ADDR_TOP);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_GetWordProxy), 2, true);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_GetWordProxy), 2, Jitter::CJitter::RETURN_VALUE_32);
m_codeGen->PullRel(offsetof(CMIPS, m_State.nCOP2VI[m_nIT]));
}
@ -781,7 +781,7 @@ void CMA_VU::CLower::XITOP()
//Compute Address
m_codeGen->PushCst(CVpu::VU_ADDR_ITOP);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_GetWordProxy), 2, true);
m_codeGen->Call(reinterpret_cast<void*>(&MemoryUtils_GetWordProxy), 2, Jitter::CJitter::RETURN_VALUE_32);
VUShared::PullIntegerRegister(m_codeGen, m_nIT);
}

View file

@ -670,7 +670,7 @@ void VUShared::ADDi(CMipsJitter* codeGen, uint8 nDest, uint8 nFd, uint8 nFs, uin
codeGen->PushRel(offsetof(CMIPS, m_State.nCOP2[nFs].nV[i]));
codeGen->PushRel(offsetof(CMIPS, m_State.nCOP2I));
codeGen->Call(reinterpret_cast<void*>(&FpAddTruncate), 2, true);
codeGen->Call(reinterpret_cast<void*>(&FpAddTruncate), 2, Jitter::CJitter::RETURN_VALUE_32);
codeGen->PullRel(offsetof(CMIPS, m_State.nCOP2[nFd].nV[i]));
}
#else

View file

@ -415,7 +415,7 @@ void CVuBasicBlock::EmitXgKick(CMipsJitter* jitter)
//Compute Address
jitter->PushCst(CVpu::VU_ADDR_XGKICK);
jitter->Call(reinterpret_cast<void*>(&MemoryUtils_SetWordProxy), 3, false);
jitter->Call(reinterpret_cast<void*>(&MemoryUtils_SetWordProxy), 3, Jitter::CJitter::RETURN_VALUE_NONE);
}
void CVuBasicBlock::ComputeSkipFlagsHints(const std::vector<uint32>& fmacStallDelays, std::vector<uint32>& hints) const